Skip to content

Conversation

@EladGabay
Copy link

@EladGabay EladGabay commented Jan 27, 2026

Add a new drainability rule that checks for the annotation cluster-autoscaler.kubernetes.io/skip-reschedule: "true"

Pods with this annotation will:

  • Be evictable (can be terminated during scale-down)
  • Receive SkipDrain status (not simulated for rescheduling)
  • NOT be included in template nodes (unlike daemonset-pod annotation)

Use case: Ephemeral pods that don't need to survive node deletion and don't need destination simulation. The pod will simply be terminated when the node is removed.

This differs from the daemonset-pod annotation which causes pods to be included in template nodes, potentially breaking pod anti-affinity rules during scale-up evaluation.

Ref: #9110

/kind feature

Add skip-reschedule annotation to skip rescheduling simulation

Add a new drainability rule that checks for the annotation
cluster-autoscaler.kubernetes.io/skip-reschedule: "true"

Pods with this annotation will:
- Be evictable (can be terminated during scale-down)
- Receive SkipDrain status (not simulated for rescheduling)
- NOT be included in template nodes (unlike daemonset-pod annotation)

Use case: Ephemeral pods that don't need to survive node deletion
and don't need destination simulation. The pod will simply be
terminated when the node is removed.

This differs from the daemonset-pod annotation which causes pods
to be included in template nodes, potentially breaking pod
anti-affinity rules during scale-up evaluation.

Ref: kubernetes#9110
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 27, 2026
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

Welcome @EladGabay!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @EladGabay. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EladGabay
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 27, 2026
@@ -0,0 +1,64 @@
/*
Copyright 2026 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going forward we are dropping the year from boilerplate on new source files, CI will be happy if you replace this with Copyright The Kubernetes Authors.

Ref:

thank you!

@jackfrancis
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2026
@jackfrancis
Copy link
Contributor

@EladGabay could you kindly follow the EasyCLA flow and sign the CLA? Thank you!

@jackfrancis
Copy link
Contributor

/release-note-edit

Add skip-reschedule annotation to skip rescheduling simulation

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants