-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add skip-reschedule annotation to skip rescheduling simulation #9134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add a new drainability rule that checks for the annotation cluster-autoscaler.kubernetes.io/skip-reschedule: "true" Pods with this annotation will: - Be evictable (can be terminated during scale-down) - Receive SkipDrain status (not simulated for rescheduling) - NOT be included in template nodes (unlike daemonset-pod annotation) Use case: Ephemeral pods that don't need to survive node deletion and don't need destination simulation. The pod will simply be terminated when the node is removed. This differs from the daemonset-pod annotation which causes pods to be included in template nodes, potentially breaking pod anti-affinity rules during scale-up evaluation. Ref: kubernetes#9110
|
|
Welcome @EladGabay! |
|
Hi @EladGabay. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: EladGabay The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @@ -0,0 +1,64 @@ | |||
| /* | |||
| Copyright 2026 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going forward we are dropping the year from boilerplate on new source files, CI will be happy if you replace this with Copyright The Kubernetes Authors.
Ref:
thank you!
|
/ok-to-test |
|
@EladGabay could you kindly follow the EasyCLA flow and sign the CLA? Thank you! |
|
/release-note-edit |
Add a new drainability rule that checks for the annotation cluster-autoscaler.kubernetes.io/skip-reschedule: "true"
Pods with this annotation will:
Use case: Ephemeral pods that don't need to survive node deletion and don't need destination simulation. The pod will simply be terminated when the node is removed.
This differs from the daemonset-pod annotation which causes pods to be included in template nodes, potentially breaking pod anti-affinity rules during scale-up evaluation.
Ref: #9110
/kind feature