Skip to content

fix(ca): Fix pre-commit hook trigger #9129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kincoy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ca): Fix pre-commit hook trigger #9129

kincoy wants to merge 1 commit into from

Conversation

@kincoy
Copy link
Contributor

@kincoy kincoy commented Jan 27, 2026 •
edited
Loading

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

This PR fixes a broken pre-commit hook and restores the usability of the update-faq-flags script.

Specifically:

  • Fixes the pre-commit hook file matcher after flags.go was moved out of main.go, which previously caused the hook to never trigger.
  • Makes hack/update-faq-flags.sh work on macOS by handling the lack of grep -P support.
  • Makes flag table header matching more robust against whitespace-only changes.
  • Fixes awk failures when replacing multi-line markdown tables by passing generated content via a temporary file.

Without these changes, the flag table update hook is silently skipped and the script cannot be reliably run on non-GNU environments.

Special notes for your reviewer:

  • FAQ.md was regenerated by manually running the updated script to reflect the latest flags.
  • The changes are limited to tooling and documentation generation logic and do not affect autoscaler runtime behavior.

Does this PR introduce a user-facing change?

None

@kincoy
fix(ca): Fix pre-commit hook trigger and make update-faq-flags script…
ca85b3d 
… portable

- Fix pre-commit hook file pattern after flags.go was moved out of main.go,
  otherwise the update-faq-flags hook is never triggered.
- Make update-faq-flags.sh work on macOS by handling lack of grep -P support.
- Make flag table header matching more robust against whitespace changes.
- Avoid awk parsing failures by passing multiline table content via temp file
  instead of embedding it directly in awk variables.

These changes restore the intended behavior of the pre-commit hook and
make the flag table generation script usable across platforms.

Signed-off-by: kincoy <kincoyao@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Jan 27, 2026
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 27, 2026

Hi @kincoy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kincoy
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-area do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianmoisey adrianmoisey Awaiting requested review from adrianmoisey

@elmiko elmiko Awaiting requested review from elmiko

Assignees

No one assigned

Labels

area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kincoy @k8s-ci-robot