Kamatera cloudprovier refactor #9123
Conversation
# Conflicts: # cluster-autoscaler/cloudprovider/kamatera/kamatera_cloud_provider_test.go
…d-improve-operati
…ertions-and-improve-operati Add Kamatera interface assertions and verbose logs
## Summary - Add LF/CRLF line continuation coverage for `default-ssh-key` in Kamatera config tests - Validate parsed SSH key concatenation for multiline entries Co-authored-by: opencode <ori+opencode@uumpa.com> Co-committed-by: opencode <ori+opencode@uumpa.com>
refactor kubeconfig fix memory units add cloud provider id set http timeout add locking + tests add interface assertions and logs reduce queue polling log spam #5 refactor kubeconfig #1 fix memory units #2 add cloud provider id #4 set http timeout add locking + tests fix cloud provider id Add Kamatera interface assertions and logs Test multiline default ssh key parsing (#2) ## Summary - Add LF/CRLF line continuation coverage for `default-ssh-key` in Kamatera config tests - Validate parsed SSH key concatenation for multiline entries Co-authored-by: opencode <ori+opencode@uumpa.com> Co-committed-by: opencode <ori+opencode@uumpa.com> test fix fix kamatera cloudprovider id Kamatera: reduce queue polling log spam log fixes
kamatera fixes for poweron/off scale up/down kamatera cloudprovider stability fixes kamatera fix handling of powered off nodes + improve logs kamatera cloudprovider: change server commands to be async
k8s-ci-robot
added
release-note
|
Hi @OriHoch. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: OriHoch The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
@OriHoch i looked at the |
hi yes I'm the primary maintainer but I think because I'm not an org member I can't be set in the OWNERS.. |
|
ah, ok. thanks for the information. if you would like help joining the org, i'm happy to assist. otherwise, i will try to help here as i can with the review. |
3 participants
What type of PR is this?
/kind bug
/kind cleanup
/kind feature
What this PR does / why we need it:
After running the Kamatera cloudprovider for some customers a few months this PR does a lot of fixes and improvements from feedback we got.
Special notes for your reviewer:
Changes were well tested using our internal end-to-end testing suite on Kamatera infrastructure. Also, many unit tests were added.
Does this PR introduce a user-facing change?