-
Notifications
You must be signed in to change notification settings - Fork 515
Add e2e test target for k8s main with WAS enabled #8935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: IrvingMg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test pull-kueue-test-e2e-main-1-34 This looks like a flaky issue unrelated to these changes. Opened: #8938 |
mimowo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @kannon92 @sohankunkerkar ptal
sohankunkerkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Could you run this test in CI something similar to 60f857c#diff-23f8123955f3fa9646deaef30d6463b18df3abe77e5a0dfc5ffedea069ce193dR140?
| apiServer: | ||
| extraArgs: | ||
| enable-aggregator-routing: \"true\" | ||
| runtime-config: \"scheduling.k8s.io/v1alpha1=true\" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC This will need to be bumped to beta when they graduate Workload API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can add a TODO to update this to Beta if WAS goes beta in 1.36, which I think is still an open question.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds Make targets to run e2e tests against Kubernetes main branch with WAS feature gates enabled.
Which issue(s) this PR fixes:
Part of #8858
Special notes for your reviewer:
Companion test-infra PR: kubernetes/test-infra#36359
Does this PR introduce a user-facing change?