Skip to content

Comments

Fix condition in retrieveJobAttachments#3595

Merged
hmiguim merged 1 commit intodevelopmentfrom
eteixeira-dev-retrieveJobAttachment
Feb 20, 2026
Merged

Fix condition in retrieveJobAttachments#3595
hmiguim merged 1 commit intodevelopmentfrom
eteixeira-dev-retrieveJobAttachment

Conversation

@eduardojst10
Copy link
Contributor

  • path-scope validation bug in retrieveJobAttachment
  • startsWith check was reversed and now correctly validates that the resolved attachment path starts with the attachments base directory

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 13, 2026
@dosubot
Copy link

dosubot bot commented Feb 13, 2026

Related Documentation

Checked 5 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@dosubot dosubot bot added the bug label Feb 13, 2026
@hmiguim hmiguim merged commit bce32ff into development Feb 20, 2026
5 checks passed
@hmiguim hmiguim deleted the eteixeira-dev-retrieveJobAttachment branch February 20, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants