Prevent unnecessary desktop WebView recreation during recomposition#29
Merged
kdroidFilter merged 1 commit intokdroidFilter:mainfrom Mar 6, 2026
Merged
Prevent unnecessary desktop WebView recreation during recomposition#29kdroidFilter merged 1 commit intokdroidFilter:mainfrom
kdroidFilter merged 1 commit intokdroidFilter:mainfrom
Conversation
…d host is displayable
|
@kdroidFilter Tested it, and it works fine! |
Owner
|
Awesome work ! thanks you very much ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
On desktop, the WebView could be recreated during recomposition even when there was no actual state change or real disposal event, such as during resizing or when it doesn't leave the composition completely.
This caused the native Wry WebView to be recreated and the page to reload unnecessarily.
This PR improves that behavior by ensuring the WebView is recreated only when it truly leaves the composition.
It also adds an extra displayability check for the host panel after Skiko initialization, which makes WebView creation more stable.
Summary of changes
webViewfield tonativeWebViewinIWebViewfor better clarity