Keystone: Endpoint controller by winiciusallan · Pull Request #614 · k-orc/openstack-resource-controller

winiciusallan · 2025-12-17T14:27:21Z

This PR introduces the Keystone Endpoint controller.

Fixes: #592

Reviewer notes:

At this time, Gophercloud requires the Name field on creation, and name is deprecated according to the docs, so since I can't omit it for now, I have decided to implement the controller with this field. I opened a PR to address it
Also, we couldn't set a value for the enabled field on creation neither on update, so I have to omit it mainly in the tests. This PR was opened to fix it,

mandre

I wasn't sure at first, but I now believe we should wait for the next gophercloud release to avoid the introduction of a backward incompatible change in the API when we drop the Name field.

api/v1alpha1/endpoint_types.go

mandre · 2026-01-02T10:22:31Z

api/v1alpha1/endpoint_types.go

-	// description is a human-readable description for the resource.
+	// enabled indicates whether the endpoint is enabled or not.
+	// +optional
+	Enabled *bool `json:"enabled,omitempty"`


We can drop the pointer in the status.

I need to stop copy pasting field definitions on status 😅. Done!

My bad, this was bad advice. We actually want the pointer to differentiate between false and unset, like we do for other resources.

api/v1alpha1/endpoint_types.go

mandre · 2026-01-02T10:26:58Z

README.md

 | **controller**              | **1.x** | **2.x** | **main** |
 |:---------------------------:|:-------:|:-------:|:--------:|
 | domain                      |         |    ✔    |     ✔    |
+| endpoint                    |         |    ◐    |     ◐    |


I believe we can make it a ✔ when we're based on a newer gophercloud.

This was probably lost in a rebase. From my point of view, we've implemented the resource fully and should use ✔

Regarding the fields, all are implemented, but I've avoided putting the ✔ because the description remains immutable. Do you think I should replace it anyway?

That's what I figured afterward. It's fine to leave it like that, but I wouldn't be shocked if we moved it to ✔ either (since the legend says "mostly implemented").

cmd/resource-generator/main.go

...nal/controllers/endpoint/tests/endpoint-import-dependency/03-delete-import-dependencies.yaml

winiciusallan · 2026-01-07T13:11:01Z

Hey, sorry for the delay. Now that we have a new gophercloud release, can we get this one #628?

Once merged, I'll focus on addressing your comments and taking it further.

winiciusallan · 2026-01-07T23:49:18Z

@mandre I noticed that I missed a pointer on Description in endpoint.UpdateOpts 😅, so we are not able to unset that field; tests has been falling on endpoint-update. When we pass the zero-value, it omits the field and does not update it =/. I opened a PR for it.

Is it okay if we ignore it for now and implement it later (considering that a gophercloud release was launched recently)?

https://github.com/gophercloud/gophercloud/blob/main/openstack/identity/v3/endpoints/requests.go#L137

mandre · 2026-01-08T07:54:24Z

@mandre I noticed that I missed a pointer on Description in endpoint.UpdateOpts 😅, so we are not able to unset that field; tests has been falling on endpoint-update. When we pass the zero-value, it omits the field and does not update it =/. I opened a PR for it.

Is it okay if we ignore it for now and implement it later (considering that a gophercloud release was launched recently)?

Absolutely, let's make Description immutable for now. While your gophercloud patch is good, it's going to take time before we can consume your fix as we won't be able to backport to v2.

github-actions · 2026-01-10T01:15:59Z

Failed to assess the semver bump. See logs for details.

github-actions · 2026-01-10T01:20:18Z

Failed to assess the semver bump. See logs for details.

winiciusallan · 2026-01-10T01:37:01Z

I made a bit of mess with the commits here, sorry about that. I made a rebase instead of merging with the main branch. I think now it is good.

winiciusallan · 2026-01-10T01:42:33Z

I have amended the merge with the main branch in the last commit, it could be hard to review. I can revert and separate them if you prefer, sorry about that too =/.

mandre · 2026-02-05T07:38:59Z

Hey @winiciusallan, are you still working on this branch? From what I can tell, there are 3 significant commits:

e367bc0 (endpoint: generate code with scaffolding tool)
2783f0e (keystone: endpoint controller implementation)
50f2218 (change: drop name field, add description and enabled)

If you rebase on main, you should be able to drop the extra commits and fix the merge conflict on internal/controllers/port/actuator.go. If you feel this PR is ready to go, you might want to squash the last 2 commits together as well.

Let me know when this is ready for a final review.

winiciusallan · 2026-02-05T07:49:29Z

@mandre Hey, I'll work on the final adjustments today or tomorrow at the latest. I'll let you know when it'll be ready.

winiciusallan · 2026-02-07T02:42:43Z

@mandre Okay, now it is ready for a final review.

api/v1alpha1/endpoint_types.go

mandre · 2026-02-11T15:03:56Z

README.md

 | **controller**              | **1.x** | **2.x** | **main** |
 |:---------------------------:|:-------:|:-------:|:--------:|
 | domain                      |         |    ✔    |     ✔    |
+| endpoint                    |         |    ◐    |     ◐    |


This was probably lost in a rebase. From my point of view, we've implemented the resource fully and should use ✔

internal/controllers/endpoint/actuator.go

api/v1alpha1/endpoint_types.go

internal/controllers/endpoint/actuator.go

api/v1alpha1/endpoint_types.go

go run ./cmd/scaffold-controller \ -interactive=false \ -kind Endpoint \ -gophercloud-client NewIdentityV3 \ -gophercloud-module github.com/gophercloud/gophercloud/v2/openstack/identity/v3/endpoints \ -required-create-dependency Service \ -import-dependency Service Signed-off-by: Winicius Silva <winiciusab12@gmail.com>

api/v1alpha1/endpoint_types.go

config/samples/openstack_v1alpha1_endpoint.yaml

github-actions bot added the semver:major Breaking change label Dec 17, 2025

winiciusallan force-pushed the endpoint-controller branch 2 times, most recently from 16996dd to 2783f0e Compare December 17, 2025 17:14

mandre reviewed Jan 2, 2026

View reviewed changes

github-actions bot removed the semver:major Breaking change label Jan 10, 2026

winiciusallan force-pushed the endpoint-controller branch from b59f331 to 8e505db Compare January 10, 2026 01:25

github-actions bot added the semver:major Breaking change label Jan 10, 2026

winiciusallan force-pushed the endpoint-controller branch from 8e505db to 50f2218 Compare January 10, 2026 01:35

winiciusallan force-pushed the endpoint-controller branch 3 times, most recently from 634dbf1 to 4d3e5db Compare February 7, 2026 02:18

mandre reviewed Feb 11, 2026

View reviewed changes

api/v1alpha1/endpoint_types.go Show resolved Hide resolved

winiciusallan force-pushed the endpoint-controller branch 2 times, most recently from ad77fb6 to e932efb Compare February 12, 2026 17:07

mandre reviewed Feb 13, 2026

View reviewed changes

api/v1alpha1/endpoint_types.go Show resolved Hide resolved

api/v1alpha1/endpoint_types.go Outdated Show resolved Hide resolved

config/samples/openstack_v1alpha1_endpoint.yaml Outdated Show resolved Hide resolved

keystone: endpoint controller implementation

c1a0b5f

winiciusallan force-pushed the endpoint-controller branch from e932efb to c1a0b5f Compare February 13, 2026 10:55

mandre approved these changes Feb 13, 2026

View reviewed changes

mandre added this pull request to the merge queue Feb 13, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026

mandre added this pull request to the merge queue Feb 13, 2026

Merged via the queue into k-orc:main with commit 5a940ed Feb 13, 2026
9 checks passed

winiciusallan deleted the endpoint-controller branch February 13, 2026 17:21

Conversation

winiciusallan commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

winiciusallan commented Jan 7, 2026

Uh oh!

winiciusallan commented Jan 7, 2026

Uh oh!

mandre commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

winiciusallan commented Jan 10, 2026

Uh oh!

winiciusallan commented Jan 10, 2026

Uh oh!

mandre commented Feb 5, 2026

Uh oh!

winiciusallan commented Feb 5, 2026

Uh oh!

winiciusallan commented Feb 7, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

winiciusallan commented Dec 17, 2025 •

edited

Loading