Fix for allowing property which begins with an underscore#71
Open
1Jesper1 wants to merge 3 commits intojoomla-framework:3.x-devfrom
Open
Fix for allowing property which begins with an underscore#711Jesper1 wants to merge 3 commits intojoomla-framework:3.x-devfrom
1Jesper1 wants to merge 3 commits intojoomla-framework:3.x-devfrom
Conversation
rdeutz
reviewed
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Summary of Changes
See #68
Properties which begin with an underscore are now excluded from cleaning.
Previously properties which had an underscore as the 2nd character were excluded from cleaning.
Testing Instructions
Added test.
Documentation Changes Required
Could be a breaking change for existing code.