Only update desired key in python.analysis.diagnosticSeverityOverrides#120
Open
jrwagz wants to merge 5 commits intojoedevivo:mainfrom
Open
Only update desired key in python.analysis.diagnosticSeverityOverrides#120jrwagz wants to merge 5 commits intojoedevivo:mainfrom
python.analysis.diagnosticSeverityOverrides#120jrwagz wants to merge 5 commits intojoedevivo:mainfrom
Conversation
This should ensure that only the config key we care about is updated, and not every other config that the user has set. As mentioned in joedevivo#105
Contributor
|
Should probably also just set |
Owner
|
Merged #123, which I think covers this as well |
Contributor
|
Yes it should @joedevivo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should ensure that only the config key we care about is updated, and not every other config that the user has set.
As mentioned in #105
I am NOT a TypeScript developer, but I am a Python developer. So please review this carefully, as I am not sure how to properly test it, nor do I write TypeScript professionally.