Conversation
…etes-agent chart Signed-off-by: Richard Wall <richard.wall@venafi.com>
wallrj
commented
Nov 12, 2024
Member
Author
There was a problem hiding this comment.
I think it's OK to install the RBAC for viewing Firefly custom resources on clusters without Firefly CRD installed.
tfadeyi
approved these changes
Nov 12, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small part of the work to remove spurious log messages: https://venafi.atlassian.net/browse/VC-33564
In #507 we added a Firefly datagatherer to the venafi-kubernetes-agent chart configmap, but forgot to add RBAC to allow venafi-kubernetes-agent to read the firefly issuer resources.
This causes the following errors to be logged:
Here I've manually added the missing RBAC to the Helm chart.