fixes #337 by setting the client properly#345
fixes #337 by setting the client properly#345mivola wants to merge 2 commits intojenkinsci:masterfrom
Conversation
|
Travis failed b/c of one test: NoExecutorStartedGetJobXmlIT.getJobXmlShouldReturnTheExpectedConfigXml(). I can easily fix this test by adjusting the expected XML, but I wonder if this is really a useful test? |
| <defaultExcludes>true</defaultExcludes> | ||
| <caseSensitive>true</caseSensitive> | ||
| </hudson.tasks.ArtifactArchiver> | ||
| </publishers> |
There was a problem hiding this comment.
Can you explain why you have change the content of that file?
There was a problem hiding this comment.
Well, I need a job that actually does archive some files to get a proper Artifact object in NoExecutorStartedGetJobDetailsIT#shouldCheckTheBuildCause().
| assertThat(details.getArtifacts()).isNotNull(); | ||
| assertThat(details.getArtifacts().size()).isEqualTo(2); | ||
| details.getArtifacts().forEach(a -> assertThat(a.getClient()).isNotNull()); | ||
|
|
There was a problem hiding this comment.
Is there a good reason why you changed the behaviour of this integration test?
There was a problem hiding this comment.
Yes, this is required to test that "artifact.getClient()" is properly set (i.e. not null). But I guess it might be better to have a dedicated test method instead?
update from upstream/master
2 participants
No description provided.