Merged
Conversation
jbeder
reviewed
Feb 11, 2026
Owner
jbeder
left a comment
jbeder
left a comment
There was a problem hiding this comment.
I don't understand - isn't this minimum version listed?
Contributor
Author
|
The range syntax of this command is confusing. The left side of the range is minimum version supported. But the right side tells cmake which policies to enable. Meaning, up to which cmake version it had been tested with, because breaking changes in cmake are done via policies. New cmake version removes support of "old" behavior for old policies, so basically requires many of policies added long time ago to be in "new" state. The top-level cmake lists already has this range here |
jbeder
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.