Merged
Conversation
msdemlei
previously approved these changes
Nov 18, 2025
Collaborator
msdemlei
left a comment
msdemlei
left a comment
There was a problem hiding this comment.
Let's go for it (and I suggest a squash-merge even though there are a few other changes than just the service_ivoid).
msdemlei
approved these changes
Nov 19, 2025
Collaborator
msdemlei
left a comment
msdemlei
left a comment
There was a problem hiding this comment.
Fine with me, let's go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include Markus review
Finally, I agree that section 6 and section 3.1 (condition for citation) are not useful.
Instead of section 3.1, I added an APA template in Appendix (to motivate people and to illustrate the metadata)
I remove column "Level" and add "recommended metadata" in the text . to check if relevant ?
I skip the reason explaining that ivoid is not used for citation "because it is a technical identifier with no provisions for persistence" - Even, if ivoid is not citable, I don't think it is the role of DataOrigin to give a reason.