Refactor attribute_of_binary to reduce instantiation cost#66
Merged
Conversation
attribute_of_binaryattribute_of_binary to reduce instantiation cost
Member
|
I'm not sure why, but it seems it's getting worse in some cases.
Maybe these lines should also be lightened: x4/include/iris/x4/operator/alternative.hpp Lines 43 to 47 in aa3a7f1 This was part of the recent PR #55, and the PR added another complexity in the attribute type, I think. P.S. The refactored code itself is very good, more readable for humans so it's better if we could keep the simple structure and solve the IDE heaviness at the same time. |
saki7
reviewed
Mar 4, 2026
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









fixes #56