Skip to content

Fix StringLike for non-string-like range#48

Merged
saki7 merged 2 commits intomainfrom
fix-string-like
Mar 5, 2026
Merged

Fix StringLike for non-string-like range#48
saki7 merged 2 commits intomainfrom
fix-string-like

Conversation

@saki7
Copy link
Member

@saki7 saki7 commented Mar 5, 2026

Using CTAD of the form std::basic_string_view{some_type} yields hard error when some_type is a range that can be accepted by the constructor while having some non-desired traits specified in [strings.general]/1.

@saki7 saki7 self-assigned this Mar 5, 2026
@saki7 saki7 added the bug Something isn't working label Mar 5, 2026
@saki7 saki7 changed the title Add test for StringLike Fix StringLike for non-string-like range Mar 5, 2026
@saki7 saki7 marked this pull request as ready for review March 5, 2026 08:41
@cppwarningnotifier
Copy link

EnvironmentC++23C++26
irisClang21Debug✅success✅success
Release✅success✅success
GCC14Debug✅success✅success
Release✅success✅success
MSVC2022Debug✅success✅success
Release✅success✅success
2026Debug✅success✅success
Release✅success✅success

@saki7 saki7 merged commit fe9e3a1 into main Mar 5, 2026
34 checks passed
@saki7 saki7 deleted the fix-string-like branch March 5, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant