Conversation
This commit enables selective use of SR-MPLS for a subset of lab address families. It also introduces explicit checks of device feature SR-MPLS AF support
There was a problem hiding this comment.
Pull request overview
Enables selective SR-MPLS activation per address family (AF) and adds device feature checks to prevent configuring SR-MPLS on unsupported AFs.
Changes:
- Added
sr.af(global + node) attribute schema and documented how to constrain SR-MPLS to IPv4/IPv6 subsets. - Implemented per-device SR-MPLS AF support validation during SR module transformation.
- Updated device feature definitions to declare supported SR-MPLS AFs and added coverage tests for the new validation behavior.
Reviewed changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/coverage/errors/sr-af.yml | New negative test topology covering SR-MPLS AF support validation. |
| tests/coverage/errors/sr-af.log | Expected error output for SR-MPLS AF support validation failures. |
| netsim/modules/sr.yml | Adds sr.af attribute schema and declares af as an SR feature capability. |
| netsim/modules/sr.py | Creates/uses sr.af and checks device feature support per AF before generating Node SIDs. |
| netsim/modules/init.py | Guards module dependency requirement merging to only run on dict-like (Box) feature data. |
| netsim/devices/sros.yml | Declares SR-MPLS AF support via features.sr.af. |
| netsim/devices/srlinux.yml | Declares SR-MPLS AF support via features.sr.af. |
| netsim/devices/none.yml | Declares SR-MPLS AF support via features.sr.af. |
| netsim/devices/junos.yml | Declares SR-MPLS AF support via features.sr.af. |
| netsim/devices/iol.yml | Declares SR-MPLS AF support via features.sr.af. |
| netsim/devices/frr.yml | Declares SR-MPLS AF support via features.sr.af. |
| netsim/devices/eos.yml | Declares SR-MPLS AF support via features.sr.af. |
| netsim/devices/csr.yml | Declares SR-MPLS AF support via features.sr.af. |
| docs/module/sr-mpls.md | Documents sr.af controls (global and per-node) for SR-MPLS AF selection. |
* Add 'node_proto_af' function that calculates the default value of per-protocol 'af' dictionary for protocols that are not enabled on interfaces
ipspace
added a commit
that referenced
this pull request
Feb 18, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables selective use of SR-MPLS for a subset of lab address families. It also introduces explicit checks of device feature SR-MPLS AF support