This repository was archived by the owner on Nov 13, 2024. It is now read-only.
change video extract default output extension from png to jpg#5689
Open
mightbesimon wants to merge 1 commit intoiperov:masterfrom
Open
change video extract default output extension from png to jpg#5689mightbesimon wants to merge 1 commit intoiperov:masterfrom
png to jpg#5689mightbesimon wants to merge 1 commit intoiperov:masterfrom
Conversation
mightbesimon
force-pushed
the
master
branch
2 times, most recently
from
7aa0405 to
f13654e
Compare
Author
|
Whoops, I didn't mean to push my additional modifications (batch frame extract). Reverted back to intended. |
|
png doesn't have to be lossless though does it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In most cases,
jpgis the preferred output extension for extraction. Even the help message itself states:I think if the odd cases that require lossless
png, they should require the additional step rather than have most cases require the extra step. This will also make bulk extraction easier too. Let me know if you agree with this perspective.