fix(label): clear timeout#30850
Closed
KillerCodeMonkey wants to merge 1 commit intoionic-team:mainfrom
Closed
Conversation
- clean up setTimeout in disconnectedCallback
|
@KillerCodeMonkey is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Nice find, you'll need to clean up the build issue though, which in this case is stemming from the annoying typescript Timeout isn't a number issue. |
Contributor
Author
|
Window as global is returning a number. Nodejs is returning a Timeout object as far as i know. An clear timeout on window is accepting undefined|number. So how do you type it in general? |
Contributor
Author
|
closed in favor of #30851 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
timeouts are not cleaned up and may lead to unexpected behavior (especially in unit tests).
What is the new behavior?
Timeouts are cleaned on disconnect.
Does this introduce a breaking change?
Other information
Testrunner is vitest + angular 20 and latest ionic version 8.x