feat(button): add button inner part#30833
Open
DaveDev13 wants to merge 5 commits intoionic-team:feature-8.8from
Open
feat(button): add button inner part#30833DaveDev13 wants to merge 5 commits intoionic-team:feature-8.8from
DaveDev13 wants to merge 5 commits intoionic-team:feature-8.8from
Conversation
Issue number: resolves ionic-team#30735 --------- ## What is the current behavior? Toast's wrapper and content divs do not have part attributes. ## What is the new behavior? - Adds `wrapper` and `content` parts to Toast. ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
A small edit that will get rid of unnecessary code and give access to the inside of the button for styling To avoid unnecessary code, as in example ionic-team#29935
|
@DaveDev13 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small edit that will get rid of unnecessary code and give access to the inside of the button for styling
To avoid unnecessary code, as in example #29935
Issue number: resolves #29935
What is the current behavior?
Currently, there is no access to
.button-inner, which means there is no way to change the behavior ofjustify-content,align-itemsorflexWhat is the new behavior?
Adds access to the element in css via ::part(inner)
Does this introduce a breaking change?