[uss_qualifier] Expand and clarify --filter capability#1343
Open
BenjaminPelletier wants to merge 1 commit intointeruss:mainfrom
Open
[uss_qualifier] Expand and clarify --filter capability#1343BenjaminPelletier wants to merge 1 commit intointeruss:mainfrom
BenjaminPelletier wants to merge 1 commit intointeruss:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the --filter option only matches against the local (rather than fully-qualified) class name which means there can be collisions (for instance, across similar scenarios for F3411-19 and F3411-22a). Also, the message users see when scenarios are skipped could be more informative.
This PR attempts to make --filter more versatile and clear by matching anywhere in the scenario type, which is a standard identifier easily available in most artifact types. This adjustment maintains conceptual parity with the current implementation as I tested all of the below to work:
./monitoring/uss_qualifier/run_locally.sh configurations.dev.f3548_self_contained --filter ConflictHigherPriority./monitoring/uss_qualifier/run_locally.sh configurations.dev.f3548_self_contained --filter scenarios.astm.utm.ConflictHigherPriority./monitoring/uss_qualifier/run_locally.sh configurations.dev.f3548_self_contained --filter ^scenarios.astm.utm.ConflictHigherPriority$The documentation is updated to attempt to clearly reflect this behavior, and the message indicating the reason a scenario was skipped (seen in test report artifacts) is clarified to deliver as much information and hints as practical.