Tsk12 race parameters (#13)#333
Merged
shajoezhu merged 3 commits intoinsightsengineering:mainfrom Nov 13, 2025
Merged
Conversation
* Addition of new test cases for RACE Parametization * ADSL.RACE: Race as a Function Parameter
* Addition of new test cases for RACE Parametization * ADSL.RACE: Race as a Function Parameter * Stye and Linter fixe for RACE parametization * Linter fixe --------- Signed-off-by: DariusTETSA <46453678+DariusTETSA@users.noreply.github.com>
Contributor
Author
|
recheck |
Contributor
|
hi @kasaandras , were you going to update the cache data. thanks |
Melkiades
reviewed
Sep 26, 2025
Melkiades
reviewed
Sep 26, 2025
Melkiades
reviewed
Sep 26, 2025
Melkiades
approved these changes
Oct 16, 2025
Contributor
Melkiades
left a comment
Melkiades
left a comment
There was a problem hiding this comment.
Lgtm! Thanks for the addition ;)
* Addition of new test cases for RACE Parametization * ADSL.RACE: Race as a Function Parameter * Stye and Linter fixe for RACE parametization * Linter fixe * Have added two extra tests for when you only provide one for the Race parameters (race_list or race_prob). Also did some minor fixe on the Race parameter on the radsl * Update R/radsl.R Improve comment wording. Co-authored-by: AlexandraWall <Alexandrawall09@hotmail.co.uk> Signed-off-by: DariusTETSA <46453678+DariusTETSA@users.noreply.github.com> --------- Signed-off-by: DariusTETSA <46453678+DariusTETSA@users.noreply.github.com> Co-authored-by: AlexandraWall <Alexandrawall09@hotmail.co.uk>
Contributor
|
@shajoezhu could you take a look again? |
Contributor
|
hi @kasaandras i m adding you to the ucb_collab team, which will have write access to this repo, there is an inivte on the way, you will then be able to trigger the build next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of new test cases for RACE Parametization
ADSL.RACE: Race as a Function Parameter
Pull Request
Fixes #nnn