Skip to content

Comments

close #318 #291#323

Merged
shajoezhu merged 3 commits intomainfrom
318_mv_vignette
Feb 5, 2025
Merged

close #318 #291#323
shajoezhu merged 3 commits intomainfrom
318_mv_vignette

Conversation

@shajoezhu
Copy link
Contributor

@shajoezhu shajoezhu commented Jan 23, 2025

Pull Request

Fixes #nnn

@shajoezhu shajoezhu requested review from edelarua and pawelru and removed request for edelarua January 23, 2025 05:38
@shajoezhu shajoezhu added the sme label Jan 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Unit Tests Summary

  1 files   4 suites   29s ⏱️
 61 tests 40 ✅ 21 💤 0 ❌
106 runs  85 ✅ 21 💤 0 ❌

Results for commit c2fdadd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
metadata 💔 $8.51$ $+1.00$ $0$ $0$ $0$ $0$
rdata 💔 $10.58$ $+1.15$ $0$ $0$ $0$ $0$
row_values 💔 $8.47$ $+2.76$ $+21$ $-21$ $0$ $0$

Results for commit fcf7d23

♻️ This comment has been updated with latest results.

Melkiades
Melkiades reviewed Jan 23, 2025
View reviewed changes
Melkiades
Melkiades approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Joe :)

This was linked to issues Jan 23, 2025
move data regeneration from vignette to data-raw #318
Closed
Making updates of the cache as an exported function #291
Closed
@shajoezhu @Melkiades
Update vignettes/rebuild_cached_data.Rmd
c2fdadd 
Co-authored-by: Davide Garolini <davide.garolini@roche.com>
@shajoezhu shajoezhu merged commit ab941db into main Feb 5, 2025
30 checks passed
@shajoezhu shajoezhu deleted the 318_mv_vignette branch February 5, 2025 04:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Melkiades Melkiades Melkiades approved these changes

@pawelru pawelru Awaiting requested review from pawelru

@edelarua edelarua Awaiting requested review from edelarua

Assignees

No one assigned

Labels

sme

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

move data regeneration from vignette to data-raw Making updates of the cache as an exported function

2 participants

@shajoezhu @Melkiades