Skip to content

fix(Point): prevent ThreadLocal memory leak in StringBuilder (#1019) #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majst01 merged 1 commit into from
Feb 26, 2026
Merged

fix(Point): prevent ThreadLocal memory leak in StringBuilder (#1019) #1020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/org/influxdb/dto/Point.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public class Point {
});

private static final int DEFAULT_STRING_BUILDER_SIZE = 1024;
private static final int MAX_STRING_BUILDER_SIZE = 64 * 1024;
private static final ThreadLocal<StringBuilder> CACHED_STRINGBUILDERS =
ThreadLocal.withInitial(() -> new StringBuilder(DEFAULT_STRING_BUILDER_SIZE));

Expand Down Expand Up @@ -554,7 +555,12 @@ public String lineProtocol(final TimeUnit precision) {
// setLength(0) is used for reusing cached StringBuilder instance per thread
// it reduces GC activity and performs better then new StringBuilder()
StringBuilder sb = CACHED_STRINGBUILDERS.get();
sb.setLength(0);
if (sb.capacity() > MAX_STRING_BUILDER_SIZE) {
sb = new StringBuilder(DEFAULT_STRING_BUILDER_SIZE);
CACHED_STRINGBUILDERS.set(sb);
} else {
sb.setLength(0);
}

escapeKey(sb, measurement);
concatenatedTags(sb);
Expand Down
Loading