Skip to content

test: improve windows ui test deeplinking #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nattb8 merged 2 commits into from
Feb 24, 2026
+298 −114
Merged

test: improve windows ui test deeplinking #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a76f797
test: improve windows ui test deeplinking
nattb8 Feb 23, 2026
648c925
ci: clean up windows browsers
nattb8 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/ui-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,10 @@ jobs:
} else {
pip install -r sample/Tests/requirements-desktop.txt
}
- name: Kill leftover Brave processes
if: always()
run: |
Get-Process | Where-Object { $_.Name -like "*brave*" -or $_.Name -eq "chromedriver" } | Stop-Process -Force -ErrorAction SilentlyContinue
- name: Run UI tests
env:
UNITY_APP_PATH: Sample Unity 6 Windows.exe
Expand All @@ -324,6 +328,10 @@ jobs:
BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
working-directory: sample-unity6/Tests
run: python -m pytest -xs test/test_windows.py::WindowsTest
- name: Close Brave Browser
if: always()
run: |
Get-Process | Where-Object { $_.Name -like "*brave*" -or $_.Name -eq "chromedriver" } | Stop-Process -Force -ErrorAction SilentlyContinue
- name: Upload build log
if: always()
uses: actions/upload-artifact@v4
Expand All @@ -334,6 +342,7 @@ jobs:
test:
name: Run ${{ matrix.targetPlatform }} UI tests 🧪
needs: build
if: ${{ !cancelled() }}
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -396,6 +405,10 @@ jobs:
- name: Install dependencies (Mac)
if: contains(matrix.targetPlatform, 'StandaloneOSX') && (github.event_name != 'workflow_dispatch' || github.event.inputs.targetPlatform == 'All' || github.event.inputs.targetPlatform == matrix.targetPlatform)
run: pip install -r "${{ matrix.projectPath }}/Tests/requirements-desktop.txt"
- name: Kill leftover Brave processes (Windows)
if: matrix.targetPlatform == 'StandaloneWindows64' && always()
run: |
Get-Process | Where-Object { $_.Name -like "*brave*" -or $_.Name -eq "chromedriver" } | Stop-Process -Force -ErrorAction SilentlyContinue
- name: Run UI tests
if: github.event_name != 'workflow_dispatch' || github.event.inputs.targetPlatform == 'All' || github.event.inputs.targetPlatform == matrix.targetPlatform
env:
Expand All @@ -406,12 +419,16 @@ jobs:
BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
working-directory: ${{ matrix.projectPath }}/Tests
run: ${{ matrix.test_script }}
- name: Close Brave Browser
- name: Close Brave Browser (macOS)
if: contains(matrix.targetPlatform, 'StandaloneOSX') && always()
run: |
osascript -e 'tell application "Brave Browser" to quit' 2>/dev/null || true
sleep 2
pkill -f "Brave Browser" 2>/dev/null || true
- name: Close Brave Browser (Windows)
if: matrix.targetPlatform == 'StandaloneWindows64' && always()
run: |
Get-Process | Where-Object { $_.Name -like "*brave*" -or $_.Name -eq "chromedriver" } | Stop-Process -Force -ErrorAction SilentlyContinue
- name: Remove temporary keychain
if: contains(matrix.targetPlatform, 'StandaloneOSX') && (github.event_name != 'workflow_dispatch' || github.event.inputs.targetPlatform == 'All' || github.event.inputs.targetPlatform == matrix.targetPlatform)
run: |
Expand Down
Loading
Loading