tests: fix test_lazy_choices_help for Python 3.13+ (Fixes #1641)#1664
Open
Edward-Bennett wants to merge 2 commits intohttpie:masterfrom
Open
tests: fix test_lazy_choices_help for Python 3.13+ (Fixes #1641)#1664Edward-Bennett wants to merge 2 commits intohttpie:masterfrom
Edward-Bennett wants to merge 2 commits intohttpie:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a test called
test_lazy_choices_help, which fails on Python 3.13 and 3.14.The failure happens because
argparsestarted calling thechoicesobject when formatting help output. This causes the test’sgetter.assert_not_called()line to fail, even though the behavior is still correct.To fix this, I made the test version-aware:
This makes the test pass on all versions of Python and keeps the original behavior where possible.
Fixes #1641.