src: move State off of Request (WIP)#645
Draft
Fishrock123 wants to merge 1 commit intohttp-rs:mainfrom
Draft
Conversation
error[E0119]: conflicting implementations of trait `endpoint::Endpoint<_>`: --> src\endpoint.rs:70:1 | 54 | / impl<State, F, Fut, Res> Endpoint<State> for F 55 | | where 56 | | State: Send + Sync + 'static, 57 | | F: Send + Sync + 'static + Fn(Request) -> Fut, ... | 67 | | } 68 | | } | |_- first implementation here 69 | 70 | / impl<State, F, Fut, Res> Endpoint<State> for F 71 | | where 72 | | State: Send + Sync + 'static, 73 | | F: Send + Sync + 'static + Fn(Request, State) -> Fut, ... | 83 | | } 84 | | } | |_^ conflicting implementation
Collaborator
|
I guess the compiler thinks |
yoshuawuyts
requested changes
Jul 13, 2020
Member
yoshuawuyts
left a comment
There was a problem hiding this comment.
As per #643 (comment) this is not a direction I feel comfortable with, and I would prefer we see #642 through.
Member
Author
|
Err... this isn't solving the issue that #642 and #644 solve... this is just general ergonomics, imo? Likewise see #643 (comment) |
Member
|
One interesting implication of this PR is that it would've made #670 easier to implement; no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure I understand this error.
Fshould be a distinct type for both?? Note: the difference is inFand those compiler messages don't show enough lines for that.