feat: implement double-click auto-fit for dgrid columns#4537
Open
GordonSmith wants to merge 1 commit intohpcc-systems:mainfrom
Open
feat: implement double-click auto-fit for dgrid columns#4537GordonSmith wants to merge 1 commit intohpcc-systems:mainfrom
GordonSmith wants to merge 1 commit intohpcc-systems:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a double-click auto-fit feature for dgrid table columns, allowing users to automatically adjust column width to fit content by double-clicking the resize handle. The feature is currently marked as Work In Progress (WIP).
Changes:
- Adds double-click detection logic in dgrid-shim to emit custom events when resize handles are double-clicked
- Implements column auto-fitting in the Table component that calculates optimal width based on cell content
- Updates demo/test HTML file to showcase the new feature with multiple table examples
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| packages/dgrid-shim/src/gridHelper.ts | Adds mousedown capture listener to detect double-clicks on resize handles and dispatch dgrid-column-autofit custom event; implements resizeColumn helper method to programmatically resize columns |
| packages/dgrid/src/Table.ts | Adds _autoFitColumn method to calculate optimal column width based on data; registers event listener for dgrid-column-autofit events in update method |
| packages/dgrid/index.html | Converts from single table demo to multi-table demo showcasing both nested columns and resize handle functionality |
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
b343706 to
2947e2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gordon Smith GordonJSmith@gmail.com
WIP
Checklist:
Testing: