Changed slcan serial read routine to be faster and to manage the buffer more carefully#2028
Open
aaronfultonnz wants to merge 1 commit intohardbyte:mainfrom
Open
Changed slcan serial read routine to be faster and to manage the buffer more carefully#2028aaronfultonnz wants to merge 1 commit intohardbyte:mainfrom
aaronfultonnz wants to merge 1 commit intohardbyte:mainfrom
Conversation
…er more cauciously
zariiii9003
reviewed
Feb 14, 2026
| @@ -219,16 +219,17 @@ def _read(self, timeout: float | None) -> str | None: | |||
| # Due to accessing `serialPortOrig.in_waiting` too often will reduce the performance. | |||
| # We read the `serialPortOrig.in_waiting` only once here. | |||
| in_waiting = self.serialPortOrig.in_waiting | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| in_waiting = self.serialPortOrig.in_waiting | |
| size = self.serialPortOrig.in_waiting or 1 |
You could remove the if-else by always reading at least one.
zariiii9003
reviewed
Feb 14, 2026
| if byte: | ||
| self._buffer.extend(byte) | ||
|
|
||
| for i in range(len(self._buffer)): |
Collaborator
There was a problem hiding this comment.
Suggested change
| for i in range(len(self._buffer)): | |
| for i, byte in enumerate(self._buffer): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changes the serial read in slcan to be faster by reading all available bytes at once rather than one at a time. This is a huge performance boost (at least on windows).
Related Issues / Pull Requests