Remove pkg_resources as a dependency#286
Open
FelipeGdM wants to merge 5 commits intohaosulab:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pkg_resourcesmodule fromsetuptoolshave been deprecated and removed in python 3.12. It's still possible to use it downgradingsetuptoolsto version 81.0.0, but a long term solution would be to replace it entirelyIn this context, the goal of this PR is to replace the use of the
pkg_resourcesalong SAPIEN source codeIn order to accomplish this gaol, the recommended alternatives are importlib.resources, importlib.metadata and their backports (importlib_resources, importlib_metadata)
The
importlib.resourceslibrary provides a useful migration guide in order to move away frompkg_resources, so the implementation is pretty straightforwardAs SAPIEN aims to support python 3.8, it's also needed to perform a conditional import, as
importlib.resourcesis only available for python 3.9 or newer