Open
Conversation
First step in addressing #9044 Co-authored-by: Gemini 3.1 Pro <gemini@aistudio.google.com>
5 tasks
mcourteaux
force-pushed
the
martijn/expr-interpreter
branch
from
e836b13 to
4e4cf93
Compare
abadams
reviewed
Mar 16, 2026
src/ExprInterpreter.cpp
Outdated
| result = apply_unary(op->type, args[0], [](auto a) { return std::log(a); }); | ||
| } else if (op->name == "sqrt") { | ||
| result = apply_unary(op->type, args[0], [](auto a) { return std::sqrt(a); }); | ||
| } else if (op->is_intrinsic(Call::strict_add)) { |
Member
There was a problem hiding this comment.
This should just be:
if (op->is_strict_intrinsic()) {
Expr lowered = unstrictify_float(op);
lowered.accept(this);
}
Also instead of interpreting the fixed-point instrinsics (e.g. halving add), in the else case at the bottom you can call lower_intrinsic(op) and try again.
Contributor
Author
There was a problem hiding this comment.
I'll leave strict_fma and redirect it to std::fma().
Contributor
Author
There was a problem hiding this comment.
There is no helper function to tell if an intrinsic is a fixed-point intrinsic.
…rinsics via lower_intrinsics and recurse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step in addressing #9044.
Currently no tests, as that will come naturally when we add follow up PRs to address the other tasks in #9044. Although my testing when working with this on #8629 showed correct values for what it's worth.
🙏 I'd like to ask for a merge without additional tests, as I don't want to waste more time on this than needed. If we merge this, I can move forward with #8629 .