[xds] Implement A114: WRR support for custom backend metrics #12645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauravzg
force-pushed
the
wrr-custom-metrics
branch
from
186b684 to
418bd90
Compare
Updates the Weighted Round Robin (WRR) load balancing policy to support customizable utilization metrics via the `metric_names_for_computing_utilization` configuration. This allows endpoint weights to be driven by arbitrary named metrics (e.g. `named_metrics.foo`) or other standard metrics (e.g. `memory_utilization`) instead of solely `application_utilization` or the `cpu_utilization` fallback. Refactors metric resolution logic into `io.grpc.xds.internal.MetricReportUtils` to handle the new map lookup and validation requirements.
sauravzg
force-pushed
the
wrr-custom-metrics
branch
from
418bd90 to
d76e770
Compare
Contributor
Author
|
cc: @danielzhaotongliu To TAL at the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements gRFC A114: WRR Support for Custom Backend Metrics.
It updates the
weighted_round_robinpolicy to allow users to configure which backend metrics drive the load balancing weights.Key Changes
metric_names_for_computing_utilizationfield inWeightedRoundRobinLbConfig.named_metrics.foo) whenapplication_utilizationis absent.MetricReportUtils.application_utilization>custom_metrics(max valid value) >cpu_utilization.