-
Notifications
You must be signed in to change notification settings - Fork 4k
Maybe use io.grpc.Uri for target parsing in ManagedChannelRegistry #12608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ejona86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh. That's annoying for so small a usage. But it all makes sense.
FWIW, we've been moving things to testFixtures over time, since those are never shipped to users (and users have used some of our internal test utilities). So api/src/testFixtures would have been a bit better, but it's not that big of a deal and can be changed later.
OK moved it to api/src/testFixtures |
|
PTAL? I tested this internally as CR/862431843 and it seems to work. |
|
Friendly ping? If you want this done in some other way just LMK! |
|
Eric is OOO and will be back on Monday. |
| */ | ||
|
|
||
| package io.grpc.internal; | ||
| package io.grpc.testing; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have the same package name as what it is helping test. So this would just be io.grpc. io.grpc.testing is already being used by grpc-testing.
Will not squash.