fix: Dataloader helper Try classcast exception#177
fix: Dataloader helper Try classcast exception#177ameerabdul wants to merge 1 commit intographql-java:masterfrom
Conversation
| valuesInKeyOrder.set(listIndex, Try.succeeded(v)); | ||
| } | ||
| } | ||
| List<V> assembledValues = valuesInKeyOrder.stream().map(Try::get).collect(toList()); |
There was a problem hiding this comment.
this might be a bigger change as I can't go a Try.get on failed instances
|
Can we please have a unit test showing this working. Its not enough to fix the code, we need to lock in that behavior |
|
I managed to do a reproducton of this. I can confirm its a genuine problem but this is not the fix for it |
|
Hello, this pull request has been inactive for 60 days, so we're marking it as stale. If you would like to continue working on this pull request, please make an update within the next 30 days, or we'll close the pull request. |
|
Hello, as this pull request has been inactive for 90 days, we're closing this pull request. We always welcome contributions, and if you would like to continue, please open a new pull request. |
3 participants
Summary
newMappedDataLoaderWithTryandbatchingEnabledasfalseandcachingEnabledastrue.valueto which is already aTryinstance to be wrapped again in anotherTry.succeedcausing class cast exception