Bugfix: do not build nocase filters for non-String types #6351
+58
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6239
Fixes incorrect generation and execution of case-insensitive list filters (
_contains_nocase,_not_contains_nocase) for non-String types, resulting in SQL erroroperator does not exist: bytea ~~* byteagraph/src/schema/api.rs)_nocaselist filter variants when the element type supports case-insensitive operationspools: [Pool!]!(Bytes ID) no longer generates nocase filtersstore/postgres/src/relational_queries.rs)ILike/NotILikeoperations on non-String columnsUnsupportedFiltererror instead of opaque SQL failureNote: I don't think there's a way to do this without returning any kind of error, unless we silently downgrade nocase to casesensitive for non-String types, or cast other types to
::textin thewhereclause.