Skip to content

Remove jsonrpsee and implement json-rpc directly on top of axum #6315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lutter merged 4 commits into from
Feb 10, 2026
Merged

Remove jsonrpsee and implement json-rpc directly on top of axum #6315

lutter merged 4 commits into from
Feb 10, 2026
+699 −499

Conversation

@lutter
Copy link
Collaborator

@lutter lutter commented Jan 29, 2026 •
edited
Loading

This has two advantages:

  1. we have much more control over json-rpc processing, including better logging which jsonrpsee just doesn't provide, not even in the latest version (it's impossible to get at the remote_addr)
  2. we reduce the number of crates we depend on

Since our json-rpc server is very simple, there isn't a big downside to not relying on an external library for this

With this change, we log the following for each json-rpc request:

JSON-RPC call, x_forwarded_proto: unset, x_real_ip: unset, x_forwarded_for: unset, 
   remote_addr: 127.0.0.1:34382,
   params: Some(Object {"ipfs_hash": String("QmYourDeploymentHash"), "node_id": String("your_node_id")}),
   method: subgraph_reassign, component: JsonRpcServer

@lutter lutter requested a review from isum January 29, 2026 21:50
@dwerner dwerner self-requested a review February 5, 2026 16:51
isum
isum approved these changes Feb 10, 2026
View reviewed changes
Copy link
Member

@isum isum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice improvement 👍

@lutter
server/json-rpc: Replace jsonrpsee with axum
58b0f25 
Migrate the JSON-RPC admin server from jsonrpsee to axum/tower, which
are already used elsewhere in the codebase (server/graphman). This
removes the jsonrpsee dependency while maintaining full protocol
compatibility.

Changes:
- Add jsonrpc.rs: JSON-RPC 2.0 types (request, response, error, ID)
- Add error.rs: Error code mapping from SubgraphRegistrarError
- Add handlers.rs: Request dispatch and method handlers
- Add server.rs: Axum-based HTTP server with graceful shutdown
- Update lib.rs: Module structure with public exports
- Update Cargo.toml: Replace jsonrpsee with axum, serde_json, thiserror
@lutter
server/json-rpc: Log connection info with JSON-RPC call
ffde190
@lutter
server/json-rpc: Simplify handlers with to_response helper
82da721 
Consolidate the repetitive success/error handling pattern into a single
`to_response` helper function. Inline the error module into handlers.rs
and remove redundant per-handler logging (the dispatch function already
logs method, params, and connection info).
@lutter
server/json-rpc: Inline params structs into handlers as much as possible
149a0b7
@lutter lutter force-pushed the lutter/no-jsonrpsee branch from d5a499e to 149a0b7 Compare February 10, 2026 18:08
@lutter lutter merged commit 149a0b7 into master Feb 10, 2026
6 checks passed
@lutter lutter deleted the lutter/no-jsonrpsee branch February 10, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isum isum isum approved these changes

@dwerner dwerner Awaiting requested review from dwerner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lutter @isum