Open
Conversation
brohitbrose
suggested changes
Jul 14, 2020
|
|
||
| // HINT: Use the valueLane() method to instantiate the lane | ||
| // HINT: Use the .didSet() lifecycle callback to log a message showing updates to stats | ||
|
|
Contributor
There was a problem hiding this comment.
Adding some hints for intermediary statistic lanes here-ish would be nice.
Contributor
Author
There was a problem hiding this comment.
Hopefully the following comments (lines 23-30) better explain one's options for how to implement lanes. (Let me know if the wording can be made clearer.)
|
|
||
| // TODO: update stats with update logic | ||
|
|
||
| // HINT: access new data sent to histogram with |
Contributor
There was a problem hiding this comment.
Let's replace this with n.get("count").longValue() for now.
Contributor
Author
There was a problem hiding this comment.
Not sure if the comments from (41-48) get too overwhelming. If so, I can remove the #RECOMMENDED and #ALTERNATIVELY sections and just leave it at suggesting n.get("count).longValue()
Contributor
There was a problem hiding this comment.
I actually like the RECOMMENDED and ALTERNATIVELY!
brohitbrose
approved these changes
Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set out instructions in ui/README and server/README with tasks that focus on teaching basic Swim features through hands-on implementation such as:
Added TODO comments with hints in respective files to guide user where/how to follow these instructions
Points to be addressed before merge