Fix struct_padding required size to include trailing padding#4613
Open
shaoboyan091 wants to merge 2 commits intogpuweb:mainfrom
Open
Fix struct_padding required size to include trailing padding#4613shaoboyan091 wants to merge 2 commits intogpuweb:mainfrom
shaoboyan091 wants to merge 2 commits intogpuweb:mainfrom
Conversation
Per community discussion (gpuweb/gpuweb#5563), the group decided that pipeline immediateSize validation counts trailing padding bytes in the struct layout. The struct Data { a: A, @align(32) b: B } has its last member end at byte 40, but the full struct size is 64 due to alignment rounding. Update kRequiredSize from 40 to 64 to match this stricter validation rule.
Contributor
Author
|
Trailing bytes related small fix for cts, PTAL, thanks! |
Kangz
approved these changes
Mar 16, 2026
Kangz
requested changes
Mar 16, 2026
Collaborator
Kangz
left a comment
There was a problem hiding this comment.
Actually this shouldn't be needed no? Only the pipeline layout validation requires 64, but not the immediates set on the encoder.
Contributor
Author
|
Ah, good point. The layout size required 64 but setImmediates required 40. I'll make an update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per community discussion (gpuweb/gpuweb#5563), the group decided that pipeline immediateSize validation counts trailing padding bytes in the struct layout. The struct Data { a: A, @align(32) b: B } has its last member end at byte 40, but the full struct size is 64 due to alignment rounding. Update kRequiredSize from 40 to 64 to match this stricter validation rule.
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.