-
Notifications
You must be signed in to change notification settings - Fork 63
chore: remove 3.9 tests from kokoro #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the continuous integration configurations to remove references to Python 3.9 in the Kokoro environment. This change is necessary because Python 3.9 is no longer available in the Kokoro base image, ensuring that our CI pipelines continue to function correctly by transitioning to Python 3.10 for relevant tests. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes Python 3.9 tests from the Kokoro CI configuration, which is necessary as Python 3.9 has been removed from the Kokoro base image. The changes involve updating the system test session to use Python 3.10 instead of 3.9 in .kokoro/presubmit/system.cfg and noxfile.py. Additionally, the unit-3.9 test session is removed from the default nox.options.sessions list. The changes are consistent and correctly implement the stated goal. The code looks good.
3.9 has been removed from the kokoro base image, so we should remove the tests from our configs
3.9 is still tested in GitHub Actions