feat(storage): Add method to disable checksums on read object#4993
Open
vsharonlynn wants to merge 7 commits intogoogleapis:mainfrom
Open
feat(storage): Add method to disable checksums on read object#4993vsharonlynn wants to merge 7 commits intogoogleapis:mainfrom
vsharonlynn wants to merge 7 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: storage
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4993 +/- ##
==========================================
- Coverage 92.81% 92.78% -0.03%
==========================================
Files 225 225
Lines 8665 8673 +8
==========================================
+ Hits 8042 8047 +5
- Misses 623 626 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
reviewed
Mar 12, 2026
Collaborator
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Drive-by, as I may not be available tomorrow.
joshuatants
previously requested changes
Mar 12, 2026
vsharonlynn
force-pushed
the
feat/storage-disable-checksum
branch
2 times, most recently
from
565014b to
1759962
Compare
Co-authored-by: Carlos O'Ryan <coryan@google.com>
Co-authored-by: Carlos O'Ryan <coryan@google.com>
vsharonlynn
force-pushed
the
feat/storage-disable-checksum
branch
from
1759962 to
79e3754
Compare
vsharonlynn
dismissed
joshuatants’s stale review
Sorry, dismissing this because I can't see this after rebasing to latest main. PTAL at the latest version. Thank you.
coryan
reviewed
Mar 16, 2026
| /// println!("object contents={:?}", contents); | ||
| /// # Ok(()) } | ||
| /// ``` | ||
| pub fn compute_crc32c_checksum(mut self, v: bool) -> Self { |
Collaborator
There was a problem hiding this comment.
There is an inconsistency in naming here vs. compute_md5(). Consider naming this comptue_crc32c().
Comment on lines
+173
to
+176
| self.options | ||
| .checksum | ||
| .crc32c | ||
| .get_or_insert_with(Default::default); |
Collaborator
There was a problem hiding this comment.
This code path is untested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #4285.