Draft
Conversation
Add pybind11 bindings for S1Interval. Also add interface notes to the python README
Contributor
Author
|
This is a child of PR #534. Diffs are showing both PRs... not sure how to set the upstream to my fork. Leaving this in draft until we land the upstream. |
jmr
reviewed
Feb 26, 2026
| if (x_empty != y_empty) { | ||
| throw py::value_error( | ||
| "Invalid R2Rect: x and y intervals must be both empty or both " | ||
| "non-empty"); |
jmr
reviewed
Feb 26, 2026
Member
jmr
left a comment
jmr
left a comment
There was a problem hiding this comment.
I'm also not sure about the "expose all the things" approach. We've never exposed R2* in the old SWIG or new google3 bindings and no one complained.
Maybe you want to do a useful subset / the SWIG subset first.
| "order.\n\n" | ||
| "Vertex 0 is in the lower-left corner. The argument is reduced " | ||
| "modulo 4.") | ||
| .def("vertex_ij", |
Member
There was a problem hiding this comment.
A single overloaded vertex might make sense. I'm not sure and don't have strong feelings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pybind11 bindings for R1Interval, R2Point, and R2Rect
(Part of a series of addressing #524)