-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add native Go 1.23 iterator support for cursor-based pagination #3965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3965 +/- ##
==========================================
+ Coverage 93.60% 93.63% +0.02%
==========================================
Files 204 204
Lines 17411 17473 +62
==========================================
+ Hits 16298 16360 +62
Misses 912 912
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Not-Dhananjay-Mishra - feel free to review if you are currently online. I saw your emojis above. 😂 |
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
alexandear
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also extend README and example_iterators_test.go?
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
I just updated the README.md and was starting to update |
Updating README is enough, thanks. |
Fixes: #3964.
cc: @alexandear