Skip to content

Conversation

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 3, 2026

Fixes: #3964.

cc: @alexandear

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.63%. Comparing base (5126e84) to head (af11dfa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3965      +/-   ##
==========================================
+ Coverage   93.60%   93.63%   +0.02%     
==========================================
  Files         204      204              
  Lines       17411    17473      +62     
==========================================
+ Hits        16298    16360      +62     
  Misses        912      912              
  Partials      201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 3, 2026

@Not-Dhananjay-Mishra - feel free to review if you are currently online. I saw your emojis above. 😂

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Contributor

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also extend README and example_iterators_test.go?

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 4, 2026

Should we also extend README and example_iterators_test.go?

I just updated the README.md and was starting to update example_iterators_test.go but the cursor-based pagination example looks absolutely identical to the existing example, so I decided that it was unnecessary. Thoughts?

@alexandear
Copy link
Contributor

Should we also extend README and example_iterators_test.go?

I just updated the README.md and was starting to update example_iterators_test.go but the cursor-based pagination example looks absolutely identical to the existing example, so I decided that it was unnecessary. Thoughts?

Updating README is enough, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support native cursor-based pagination using Go 1.23 iterators

3 participants