Fix inconsistent Python union creator function naming#8981
Open
tmimmanuel wants to merge 1 commit intogoogle:masterfrom
Open
Fix inconsistent Python union creator function naming#8981tmimmanuel wants to merge 1 commit intogoogle:masterfrom
tmimmanuel wants to merge 1 commit intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namer_.Function()consistently for union creator function names at both definition and call site (fixes [Python] Inconsistent python generation of union creator types #8843)union_name_test.fbs) with a snake_case union name to expose the naming mismatch, per maintainer feedback on [Python] Inconsistent python generation of union creator types #8843 #8856Problem
For a union named
my_test_union, the generated code produced:def MyTestUnionCreator(...)(vianamer_.Function()→ UpperCamel)my_test_unionCreator(...)(vianamer_.Type()→ kKeep)This caused
AttributeError: module has no attribute 'my_test_unionCreator'at runtime when unpacking unions with non-UpperCamel names.
Fix
One-line change in
GenUnPackForUnioninsrc/idl_gen_python.cpp: replacednamer_.Type(enum_def)withnamer_.Function(enum_def).Test plan
union_name_test.fbsschema with snake_case union nameTestUnionCreatorNaminginpy_test.pyverifies Pack/UnPack round-tripAttributeError) and passes with itHow to test