Add DNS resolution caching using dnscache.Resolver{}#9
Open
vsouza wants to merge 2 commits intoglobocom:mainfrom
Open
Add DNS resolution caching using dnscache.Resolver{}#9vsouza wants to merge 2 commits intoglobocom:mainfrom
vsouza wants to merge 2 commits intoglobocom:mainfrom
Conversation
…n to use in httpclient
Contributor
|
Amazing work @vsouza ! |
KalilCazes
approved these changes
Jan 17, 2025
joaopaulovieira
approved these changes
Jan 21, 2025
Contributor
|
Hi, @vsouza . All good? Something like this: |
Author
|
@KalilCazes good catch, I'll fix it! |
…sure that channel will be closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to cache DNS resolutions using the dnscache package. The goal is to improve DNS resolution performance by avoiding repeated lookups for addresses that have already been resolved.
Main changes:
Motivation:
By introducing this feature, we aim to reduce the time spent on frequent DNS lookups, especially in high-load scenarios where multiple resolutions for the same domain are needed. Using dnscache, we expect to optimize the performance of HTTP requests by ensuring the cache is properly used for DNS resolutions.