Add error content on metric counter with attributes#11
Open
joaopaulovieira wants to merge 1 commit intomainfrom
Open
Add error content on metric counter with attributes#11joaopaulovieira wants to merge 1 commit intomainfrom
joaopaulovieira wants to merge 1 commit intomainfrom
Conversation
KalilCazes
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error metric recording and testing in the httpclient module.
request.go
attrsmap is always initialized before adding the"error"field in error cases, preventing panic (assignment to entry in nil map).var attrs map[string]stringattrs := map[string]string{}errorfield toattrswhen a generic error occurs.register_metrics_test.go
ErrCircuitOpen): validates increment of thecircuit_opencounter.errorscounter and the registration of theerrorattribute.WithChainCallbackto simulate errors via a custom callback.How to test
go testonregister_metrics_test.goto ensure all success and error scenarios are covered and there are no more panics.