Skip to content

Bump @faker-js/faker from 9.0.3 to 10.2.0 and fix CI failures #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d10c wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump @faker-js/faker from 9.0.3 to 10.2.0 and fix CI failures #4295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65606f2
Bump @faker-js/faker from 9.0.3 to 10.2.0 in /extensions/ql-vscode
dependabot[bot] Feb 5, 2026
13538f5
Add @faker-js to Jest transform patterns for v10 ESM support
d10c Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions extensions/ql-vscode/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion extensions/ql-vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,7 +2104,7 @@
"@babel/preset-react": "^7.27.1",
"@babel/preset-typescript": "^7.28.5",
"@eslint/js": "^9.39.2",
"@faker-js/faker": "^9.0.3",
"@faker-js/faker": "^10.2.0",
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faker-js/faker v10 declares engines.npm >=10. This repo’s package.json currently advertises engines.npm >=7.20.6, which is now lower than what this devDependency supports and can lead to installs/tests failing for contributors using npm 7–9. Consider bumping engines.npm to >=10 (or aligning it with whatever npm version is shipped with the pinned Node in .nvmrc).

Suggested change
"@faker-js/faker": "^10.2.0",
"@faker-js/faker": "^9.0.0",

Copilot uses AI. Check for mistakes.
"@github/markdownlint-github": "^0.8.0",
"@jest/environment": "^30.2.0",
"@jest/environment-jsdom-abstract": "^30.2.0",
Expand Down
1 change: 1 addition & 0 deletions extensions/ql-vscode/test/jest-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const transformScopes = [
"@lit",
"@lit-labs",
"@hpcc-js",
"@faker-js",
];
const transformPackages = [
"before-after-hook",
Expand Down
Loading