Localize Security Best Practices article to Korean#3580
Localize Security Best Practices article to Korean#3580eazyhozy wants to merge 7 commits intogithub:mainfrom
Security Best Practices article to Korean#3580Conversation
There was a problem hiding this comment.
Hello, I reviewed the translation from the top then stopped at line 52 (before "## Avoid unwanted changes with protected branches" line) because I realized that the ko/security-best-practices-for-your-project.md and root security-best-practices-for-your-project.md have different text quite a lot.
I think it would be better to continue review after those original english (untranslated) files are updated to the latest version. Let me make another PR for that.
edit) here: #3582
Committing suggested edits for a more user-friendly tone Co-authored-by: Roeniss Moon <roeniss2@gmail.com>
|
@eazyhozy are you still working on this? If not, I want to take this issue. |
|
@roeniss can you wait for me finishing this PR? I'll update soon. Thanks for your following-up. |
|
no problem |
|
TAMUOnCHAIN-identity-layer |
|
# Conflicts: # _articles/ko/security-best-practices-for-your-project.md
|
@ahpook @roeniss @tomthorogood Thank you for reviewing and improving my PR. |
|
Start the followThe best practices whenever they don't have no kind of commentary letting you know where it goes , it's all read , I'll read and read and read read |
|
Could you please clarify which part of the code needs more commentary? I'd like to make sure I'm following the best practices you mentioned. |
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
This PR adds a Korean translation of the Security Best Practices article.
Reference: https://opensource.guide/ko/security-best-practices-for-your-project/
Before (as-is)
After (to-be)