Enable contributions from Windows developers#139
Enable contributions from Windows developers#139ScottArbeit wants to merge 4 commits intogithub:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables Windows developers to contribute to the project by updating the contribution guidelines.
- Updated dependency installation instructions with platform-specific commands.
- Added separate commands for running tests on Unix-like and Windows systems.
Files not reviewed (4)
- Makefile.win: Language not supported
- script/bootstrap.ps1: Language not supported
- script/ensure-go-installed.ps1: Language not supported
- script/go.ps1: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
cc: @ttaylorr |
mhagger
left a comment
mhagger
left a comment
There was a problem hiding this comment.
I can't vet the code, but I like the sentiment!
I left one comment, more out of curiosity than as an informed suggestion. BTW two of the new files are missing a trailing EOL on their last lines.
Makefile.win
Outdated
|
|
||
| # Help target | ||
| help: | ||
| @powershell -NoProfile -ExecutionPolicy Bypass -Command "Write-Host 'Windows Makefile for git-sizer' -ForegroundColor Cyan" |
There was a problem hiding this comment.
Is there an easier way to make powershell be used for all commands rather than having to write them all out like this? Glancing at the GNU make docs, maybe setting MAKESHELL would do something like that?
There was a problem hiding this comment.
Thanks for the pointer... just cleaned that up with a variable.
2 participants
This PR adds support for Windows developers to contribute to the project. It includes PowerShell-equivalent scripts the bash scripts that set up prerequisites and dependencies, as well as a Windows-specific Makefile that uses PowerShell to execute its steps.