Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes typos in the code comments and error messages by correcting "commited" to "committed."
- Updated a comment in the raft test file.
- Corrected a comment in the Raft source file.
- Fixed two error message strings in the inflight test file.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/raft/raft_test.go | Updated typo in a comment regarding snapshots. |
| internal/raft/raft.go | Corrected typo in a comment about snapshots. |
| internal/raft/inflight_test.go | Fixed typos in error messages in tests. |
Comments suppressed due to low confidence (1)
internal/raft/raft_test.go:1392
- Typo detected: replace 'commited' with 'committed' in the comment.
// with nothing commited, asking for a snapshot should return an error
|
|
||
| // ErrNothingNewToSnapshot is returned when trying to create a snapshot | ||
| // but there's nothing new commited to the FSM since we started. | ||
| // but there's nothing new committed to the FSM since we started. |
There was a problem hiding this comment.
Typo fix confirmed: the correction from 'commited' to 'committed' is correct.
| in.Commit(1) | ||
| if in.Committed().Len() != 0 { | ||
| t.Fatalf("should not be commited") | ||
| t.Fatalf("should not be committed") |
There was a problem hiding this comment.
Typo corrected: ensure 'commited' is replaced with 'committed' in the error message.
| in.Commit(1) | ||
| if in.Committed().Len() != 1 { | ||
| t.Fatalf("should be commited") | ||
| t.Fatalf("should be committed") |
There was a problem hiding this comment.
Typo corrected: ensure 'commited' is replaced with 'committed' in the error message.
Author
|
cc @meiji163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo from
commitedtocommitted