Skip to content

Avoid inconsistent implicit toString on potential string subtypes #21318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ginsbach wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Draft

Avoid inconsistent implicit toString on potential string subtypes #21318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
final private class LangContentSet = Lang::ContentSet;

class Content extends LangContentSet {
string toString() { result = "Content" }
string toString() { result = super.toString() }
}

class ContentFilter extends Unit {
Expand Down
9 changes: 8 additions & 1 deletion shared/util/codeql/util/FileSystem.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ signature module InputSig {
* Typically `containerparent(result, this)`.
*/
ContainerBase getParentContainer();

/**
* Gets a textual representation of this container.
*
* Typically `result = this.getAbsolutePath()`.
*/
string toString();
}

/**
Expand Down Expand Up @@ -206,7 +213,7 @@ module Make<InputSig Input> {
*
* This is the absolute path of the container.
*/
string toString() { result = this.getAbsolutePath() }
string toString() { result = super.toString() }
}

/** A folder. */
Expand Down
Loading