Add Memory4 package

c/common/test/rules/objectassignedtoanoverlappingobject/ObjectAssignedToAnOverlappingObject.expected

@@ -0,0 +1 @@
+| test.c:36:3:36:18 | ... = ... | An object $@ assigned to overlapping object $@. | test.c:36:9:36:10 | m2 | m2 | test.c:36:17:36:18 | m1 | m1 |

c/common/test/rules/objectassignedtoanoverlappingobject/ObjectAssignedToAnOverlappingObject.ql

@@ -0,0 +1,4 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.objectassignedtoanoverlappingobject.ObjectAssignedToAnOverlappingObject
+
+class TestFileQuery extends ObjectAssignedToAnOverlappingObjectSharedQuery, TestQuery { }

c/common/test/rules/objectassignedtoanoverlappingobject/test.c

@@ -0,0 +1,53 @@
+struct s1 {
+  int m1[10];
+};
+struct s2 {
+  int m1;
+  struct s1 m2;
+};
+
+union u {
+  struct s1 m1;
+  struct s2 m2;
+};
+
+typedef struct {
+  char buf[8];
+} Union_t;
+
+typedef union {
+
+  unsigned char uc[24];
+
+  struct {
+    Union_t prefix;
+    Union_t suffix;
+  } fnv;
+
+  struct {
+    unsigned char padding[16];
+    Union_t suffix;
+  } diff;
+
+} UnionSecret_t;
+
+void overlapping_access() {
+  union u u1;
+  u1.m2.m2 = u1.m1; // NON_COMPLIANT, different struct. u1.m2 and u1.m1
+}
+
+void cross_copy() {
+  UnionSecret_t hash1;
+  hash1.diff.suffix =
+      hash1.fnv.suffix; // COMPLIANT (copy across structs), but safe.
+}
+
+void internal_shift() {
+  UnionSecret_t hash1;
+  hash1.fnv.prefix = hash1.fnv.suffix; // COMPLIANT, same struct.
+}
+
+void separate_access() {
+  UnionSecret_t hash1, hash2;
+  hash2.diff.suffix = hash1.fnv.suffix; // COMPLIANT, different union.
+}

c/common/test/rules/objectcopiedtoanoverlappingobject/ObjectCopiedToAnOverlappingObject.ql

@@ -0,0 +1,4 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.objectcopiedtoanoverlappingobject.ObjectCopiedToAnOverlappingObject
+
+class TestFileQuery extends ObjectCopiedToAnOverlappingObjectSharedQuery, TestQuery { }

c/misra/test/rules/RULE-19-1/test.c → c/common/test/rules/objectcopiedtoanoverlappingobject/test.c

@@ -56,4 +56,4 @@ void test_unions() {
 
   memcpy(&u1.m2.m2, &u1.m1, sizeof(u1.m1)); // NON_COMPLIANT
   memcpy(&u2.diff.suffix, &u2.fnv.suffix, sizeof(u2.fnv.suffix)); // COMPLIANT
-}
+}

c/misra/src/rules/RULE-19-1/ObjectAssignedToAnOverlappingObjectMisraC.ql

@@ -0,0 +1,23 @@
+/**
+ * @id c/misra/object-assigned-to-an-overlapping-object-misra-c
+ * @name RULE-19-1: An object shall not be assigned to an overlapping object
+ * @description An object shall not be copied or assigned to an overlapping object.
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/misra/id/rule-19-1
+ *       correctness
+ *       external/misra/c/2012/third-edition-first-revision
+ *       external/misra/obligation/mandatory
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.cpp.rules.objectassignedtoanoverlappingobject.ObjectAssignedToAnOverlappingObject
+
+class ObjectAssignedToAnOverlappingObjectMisraCQuery extends ObjectAssignedToAnOverlappingObjectSharedQuery
+{
+  ObjectAssignedToAnOverlappingObjectMisraCQuery() {
+    this = Contracts7Package::objectAssignedToAnOverlappingObjectMisraCQuery()
+  }
+}

c/misra/src/rules/RULE-19-1/ObjectCopiedToAnOverlappingObjectMisraC.ql

@@ -0,0 +1,23 @@
+/**
+ * @id c/misra/object-copied-to-an-overlapping-object-misra-c
+ * @name RULE-19-1: An object shall not be copied to an overlapping object
+ * @description An object shall not be copied to an overlapping object.
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/misra/id/rule-19-1
+ *       correctness
+ *       external/misra/c/2012/third-edition-first-revision
+ *       external/misra/obligation/mandatory
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.cpp.rules.objectcopiedtoanoverlappingobject.ObjectCopiedToAnOverlappingObject
+
+class ObjectCopiedToAnOverlappingObjectMisraCQuery extends ObjectCopiedToAnOverlappingObjectSharedQuery
+{
+  ObjectCopiedToAnOverlappingObjectMisraCQuery() {
+    this = Contracts7Package::objectCopiedToAnOverlappingObjectMisraCQuery()
+  }
+}

c/misra/test/rules/RULE-19-1/ObjectAssignedToAnOverlappingObjectMisraC.testref

@@ -0,0 +1 @@
+c/common/test/rules/objectassignedtoanoverlappingobject/ObjectAssignedToAnOverlappingObject.ql

c/misra/test/rules/RULE-19-1/ObjectCopiedToAnOverlappingObjectMisraC.testref

@@ -0,0 +1 @@
+c/common/test/rules/objectcopiedtoanoverlappingobject/ObjectCopiedToAnOverlappingObject.ql

cpp/autosar/src/rules/M0-2-1/ObjectAssignedToAnOverlappingObjectAutosarCpp.ql

@@ -0,0 +1,24 @@
+/**
+ * @id cpp/autosar/object-assigned-to-an-overlapping-object-autosar-cpp
+ * @name M0-2-1: An object shall not be assigned to an overlapping object
+ * @description An object shall not be assigned to an overlapping object.
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/autosar/id/m0-2-1
+ *       correctness
+ *       external/autosar/allocated-target/implementation
+ *       external/autosar/enforcement/automated
+ *       external/autosar/obligation/required
+ */
+
+import cpp
+import codingstandards.cpp.autosar
+import codingstandards.cpp.rules.objectassignedtoanoverlappingobject.ObjectAssignedToAnOverlappingObject
+
+class ObjectAssignedToAnOverlappingObjectAutosarCppQuery extends ObjectAssignedToAnOverlappingObjectSharedQuery
+{
+  ObjectAssignedToAnOverlappingObjectAutosarCppQuery() {
+    this = RepresentationPackage::objectAssignedToAnOverlappingObjectAutosarCppQuery()
+  }
+}

cpp/autosar/test/rules/M0-2-1/ObjectAssignedToAnOverlappingObjectAutosarCpp.testref

@@ -0,0 +1 @@
+cpp/common/test/rules/objectassignedtoanoverlappingobject/ObjectAssignedToAnOverlappingObject.ql

cpp/common/src/codingstandards/cpp/exclusions/c/Contracts7.qll

@@ -7,8 +7,8 @@ newtype Contracts7Query =
   TDoNotPassInvalidDataToTheAsctimeFunctionQuery() or
   TDoNotCallVaArgOnAVaListThatHasAnIndeterminateValueQuery() or
   TRightHandOperandOfAShiftRangeQuery() or
-  TObjectAssignedToAnOverlappingObjectQuery() or
-  TObjectCopiedToAnOverlappingObjectQuery()
+  TObjectAssignedToAnOverlappingObjectMisraCQuery() or
+  TObjectCopiedToAnOverlappingObjectMisraCQuery()
 
 predicate isContracts7QueryMetadata(Query query, string queryId, string ruleId, string category) {
   query =
@@ -39,20 +39,20 @@ predicate isContracts7QueryMetadata(Query query, string queryId, string ruleId,
   category = "required"
   or
   query =
-    // `Query` instance for the `objectAssignedToAnOverlappingObject` query
-    Contracts7Package::objectAssignedToAnOverlappingObjectQuery() and
+    // `Query` instance for the `objectAssignedToAnOverlappingObjectMisraC` query
+    Contracts7Package::objectAssignedToAnOverlappingObjectMisraCQuery() and
   queryId =
-    // `@id` for the `objectAssignedToAnOverlappingObject` query
-    "c/misra/object-assigned-to-an-overlapping-object" and
+    // `@id` for the `objectAssignedToAnOverlappingObjectMisraC` query
+    "c/misra/object-assigned-to-an-overlapping-object-misra-c" and
   ruleId = "RULE-19-1" and
   category = "mandatory"
   or
   query =
-    // `Query` instance for the `objectCopiedToAnOverlappingObject` query
-    Contracts7Package::objectCopiedToAnOverlappingObjectQuery() and
+    // `Query` instance for the `objectCopiedToAnOverlappingObjectMisraC` query
+    Contracts7Package::objectCopiedToAnOverlappingObjectMisraCQuery() and
   queryId =
-    // `@id` for the `objectCopiedToAnOverlappingObject` query
-    "c/misra/object-copied-to-an-overlapping-object" and
+    // `@id` for the `objectCopiedToAnOverlappingObjectMisraC` query
+    "c/misra/object-copied-to-an-overlapping-object-misra-c" and
   ruleId = "RULE-19-1" and
   category = "mandatory"
 }
@@ -79,17 +79,17 @@ module Contracts7Package {
       TQueryC(TContracts7PackageQuery(TRightHandOperandOfAShiftRangeQuery()))
   }
 
-  Query objectAssignedToAnOverlappingObjectQuery() {
+  Query objectAssignedToAnOverlappingObjectMisraCQuery() {
     //autogenerate `Query` type
     result =
-      // `Query` type for `objectAssignedToAnOverlappingObject` query
-      TQueryC(TContracts7PackageQuery(TObjectAssignedToAnOverlappingObjectQuery()))
+      // `Query` type for `objectAssignedToAnOverlappingObjectMisraC` query
+      TQueryC(TContracts7PackageQuery(TObjectAssignedToAnOverlappingObjectMisraCQuery()))
   }
 
-  Query objectCopiedToAnOverlappingObjectQuery() {
+  Query objectCopiedToAnOverlappingObjectMisraCQuery() {
     //autogenerate `Query` type
     result =
-      // `Query` type for `objectCopiedToAnOverlappingObject` query
-      TQueryC(TContracts7PackageQuery(TObjectCopiedToAnOverlappingObjectQuery()))
+      // `Query` type for `objectCopiedToAnOverlappingObjectMisraC` query
+      TQueryC(TContracts7PackageQuery(TObjectCopiedToAnOverlappingObjectMisraCQuery()))
   }
 }

cpp/common/src/codingstandards/cpp/exclusions/cpp/Memory4.qll

@@ -0,0 +1,44 @@
+//** THIS FILE IS AUTOGENERATED, DO NOT MODIFY DIRECTLY.  **/
+import cpp
+import RuleMetadata
+import codingstandards.cpp.exclusions.RuleMetadata
+
+newtype Memory4Query =
+  TObjectAssignedToAnOverlappingObjectMisraCppQuery() or
+  TObjectCopiedToAnOverlappingObjectMisraCppQuery()
+
+predicate isMemory4QueryMetadata(Query query, string queryId, string ruleId, string category) {
+  query =
+    // `Query` instance for the `objectAssignedToAnOverlappingObjectMisraCpp` query
+    Memory4Package::objectAssignedToAnOverlappingObjectMisraCppQuery() and
+  queryId =
+    // `@id` for the `objectAssignedToAnOverlappingObjectMisraCpp` query
+    "cpp/misra/object-assigned-to-an-overlapping-object-misra-cpp" and
+  ruleId = "RULE-8-18-1" and
+  category = "mandatory"
+  or
+  query =
+    // `Query` instance for the `objectCopiedToAnOverlappingObjectMisraCpp` query
+    Memory4Package::objectCopiedToAnOverlappingObjectMisraCppQuery() and
+  queryId =
+    // `@id` for the `objectCopiedToAnOverlappingObjectMisraCpp` query
+    "cpp/misra/object-copied-to-an-overlapping-object-misra-cpp" and
+  ruleId = "RULE-8-18-1" and
+  category = "mandatory"
+}
+
+module Memory4Package {
+  Query objectAssignedToAnOverlappingObjectMisraCppQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `objectAssignedToAnOverlappingObjectMisraCpp` query
+      TQueryCPP(TMemory4PackageQuery(TObjectAssignedToAnOverlappingObjectMisraCppQuery()))
+  }
+
+  Query objectCopiedToAnOverlappingObjectMisraCppQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `objectCopiedToAnOverlappingObjectMisraCpp` query
+      TQueryCPP(TMemory4PackageQuery(TObjectCopiedToAnOverlappingObjectMisraCppQuery()))
+  }
+}